Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement buttongrid #3546

Merged
merged 7 commits into from
Dec 29, 2023
Merged

Implement buttongrid #3546

merged 7 commits into from
Dec 29, 2023

Conversation

mueller-ma
Copy link
Member

Closes #3494

@mueller-ma
Copy link
Member Author

Using the example from https://www.openhab.org/docs/ui/sitemaps.html#element-type-buttongrid:
(the app doesn't support F7 icons, so it doesn't look exactly the same).

grafik

@mueller-ma mueller-ma marked this pull request as ready for review December 26, 2023 14:21
@lolodomo
Copy link
Contributor

lolodomo commented Dec 26, 2023

Your screenshot looks good and you use the text when encountering an unsupported icon, as expected.
In my Basic UI PR, you have an example with 12 buttongrid elements, each with a different number of columns (from 1 to 12 columns). It could be interesting to check your implementation with such a sitemap. Note that on a phone,I do not render more than 4 columns (8 on tablet(. Do you have a limit ?

Closes openhab#3494

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Copy link
Member Author

I use the same hard limit as for the regular switch with mappings: Based on screen size 4, 5, 6 or 8 columns.

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma mueller-ma merged commit 895333e into openhab:main Dec 29, 2023
7 checks passed
@mueller-ma mueller-ma deleted the buttongrid branch December 29, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Buttongrid
3 participants